-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos: hasPrerequsite -> hasPrerequisite, and others #817
Conversation
bact
commented
Jul 30, 2024
•
edited
Loading
edited
- Fix typo in hasAddedFile: "is is" -> "is"
- Fix typo in type name: "hasPrerequsite" -> "hasPrerequisite"
- Make fullstops and commas in of all types in RelationshipType consistent.
- some "during a LifecycleScopeType period" have comman before it, some don't
- some description with one sentence have fullstop, some don't
Also make fullstops and commas consistent. Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@goneall I have pushed another commit after your approval to fix: hasPrerequsite -> hasPrerequisite. There's a typo of this hasPrerequisite relationship type as well in the 2.3->3.0 translation table. I will open another PR to fix that together with the strikethrough formatting. (opened at spdx/spdx-spec#1017 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @bact
This could be a breaking change if anyone is using the incorrectly spelled 3.0.0 version.
That being said, I believe we should go ahead and merge this in now so we don't propagate the miss-spelled property further.
@zvr @kestewart - agree?
For "hasPrerequsite" -> "hasPrerequisite",
|