Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamespaceMap: fix TODO; "ElementID" -> "Element ID" #821

Merged
merged 11 commits into from
Aug 9, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Aug 9, 2024

This is a rework of #796

bact and others added 10 commits July 2, 2024 18:09
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Also use 4-space indent for bullet list, to keep the multiple paragraphs rendered correctly.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-authored-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-authored-by: Alexios Zavras (zvr) <zvr+git@zvr.gr>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
ElementID is not a specific name anywhere in the model (possibly an externalSpdxId ?)

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good - I did notice that we have a link to the SPDX 3 model repo without a specific version or commit. We can open a separate PR or issue if this needs to be solved for the ISO submission.

@kestewart kestewart merged commit 970525b into spdx:main Aug 9, 2024
1 check passed
@bact bact deleted the complete-todo-namespacemap branch August 9, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants