Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos, casing, and make SoftwarePurpose entry description consistent #885

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Fix typos, casing, and make SoftwarePurpose entry description consistent #885

merged 1 commit into from
Sep 22, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Sep 21, 2024 •
edited
Loading

  • Fix typos in model descriptions
  • Make sure that the property names have correct casing (starts with a lowercase letter) in model descriptions
    • "ExternalSpdxId identifies ..." --> "An externalSpdxId identifies ..."
  • Add "The" to entry description of SoftwarePurpose vocab (some already have, some don't; also make "The" casing consistent with entry description in other vocabs)
    • "Element ..." --> "The Element ..."

@bact
Fix typos and make entry desc format consistent
4f64ba7 
- Fix typos in model descriptions
- Make sure that the property names have correct casing (starts with a lowercase letter) in model descriptions
- Add "The" to entry description of SoftwarePurpose (some already have, some don't; also make "The" casing consistent with entry description in other vocabs)

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the documentation Improvements or additions to documentation label Sep 21, 2024
@bact bact requested a review from sbarnum September 21, 2024 12:21
@bact bact mentioned this pull request Sep 21, 2024
Open
goneall
goneall approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@zvr zvr merged commit 935a120 into spdx:main Sep 22, 2024
1 check passed
@bact bact deleted the fix-typo-buildType branch September 22, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvr zvr zvr approved these changes

@goneall goneall goneall approved these changes

@sbarnum sbarnum Awaiting requested review from sbarnum

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @zvr @goneall