Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License submission form-XML editor: exception v license #398

Open
jlovejoy opened this issue Oct 15, 2022 · 9 comments
Open

License submission form-XML editor: exception v license #398

jlovejoy opened this issue Oct 15, 2022 · 9 comments
Assignees
Labels
Submit New License Issues related to the submit new license feature

Comments

@jlovejoy
Copy link
Member

XML creator automatically uses "license" even if it's an exception. Not sure there's a way to change this as we'd probably need a way to designate it as an exception in the submission form?

@jlovejoy jlovejoy added the Submit New License Issues related to the submit new license feature label Oct 15, 2022
@goneall
Copy link
Member

goneall commented Oct 15, 2022

@jlovejoy Agree it would require some changes to the UI.

@jlovejoy
Copy link
Member Author

Some more notes on this:

  • add tick box as to license or exception in submission form
  • this then dictates the appropriate tag when creating the XML and the PR (to put the XML in the exceptions folder)

Also note: currently, if you change License --> exception in that tag, and then "beautify" it strips out the other attributions for the license/exception tag.

@HirumalPriyashan
Copy link
Contributor

Hi @jlovejoy,

Also note: currently, if you change License --> exception in that tag, and then "beautify" it strips out the other attributions for the license/exception tag.

Can you kindly explain what is meant by this line?

@jlovejoy
Copy link
Member Author

it's hard to explain in text, if you test the XML editor via one of the submissions it will make more sense. Basically, if you try to change the license tag to exception. then use the "beautify" function in the xml editor, it "corrects" the tag back to

@HirumalPriyashan
Copy link
Contributor

I see, thanks for the clarification.
I noticed beautify strips out the content of the exception tag in that case.

@jlovejoy
Copy link
Member Author

@goneall @rtgdk - looks like there are two PRs open against this issue - should we close one?

@jlovejoy
Copy link
Member Author

@BassCoder2808 - could you comment here (so I can assign you to this issue) :)

@BassCoder2808
Copy link
Contributor

Sure @jlovejoy

@jlovejoy
Copy link
Member Author

ah, the related PRs to this issue have not been merged, so won't see fix yet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Submit New License Issues related to the submit new license feature
Projects
None yet
Development

No branches or pull requests

4 participants