Fixing the issue of striping attributes when beautify #458
Conversation
…-online-tools" This reverts commit 78ec797, reversing changes made to 9b1f727.
|
@jlovejoy Can you review this? |
|
@rtgdk - I'm not sure how the functionality for the "beautify" option works or if this is all that is needed to fix this issue. Can you please review?? |
jlovejoy
added
the
Submit New License
src/app/formatxml.py
Outdated
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| INDENT = 2 | |||
| LINE_LENGTH = 80 | |||
| IS_EXCEPTION = False | |||
There was a problem hiding this comment.
Having a global variable can affect other users as well since the global value is changed. The application won't have separate instances of app for every user.
src/app/formatxml.py
Outdated
| @@ -143,7 +152,9 @@ def pretty(node, level): | |||
| text = text.replace('&', '&').replace('>', '>').replace('<', '<') | |||
| ser += text | |||
| for child in node: | |||
| ser += pretty(child, child_level) | |||
| res = pretty(child, child_level) | |||
| if not(IS_EXCEPTION and 'standardLicenseHeader' in res): | |||
There was a problem hiding this comment.
This needs to checked in the context of pretty func not at a global level I think.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -143,7 +148,9 @@ def pretty(node, level): | |||
| text = text.replace('&', '&').replace('>', '>').replace('<', '<') | |||
| ser += text | |||
| for child in node: | |||
| ser += pretty(child, child_level) | |||
| res = pretty(child, child_level) | |||
| if not('exception' in ser and 'standardLicenseHeader' in res): | |||
There was a problem hiding this comment.
E275: missing whitespace after keyword
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Help us improve LIFT! (Sonatype LiftBot external survey)
Was this a good recommendation for you? Answering this survey will not impact your Lift settings.
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
@sonatype-lift ignore
There was a problem hiding this comment.
I've recorded this as ignored for this pull request.
If you change your mind, just comment @sonatype-lift unignore.
|
@BanulaKumarage @rtgdk - Should this be merged? |
formatlXml.pyby adding exception with its allowed attributes.standardLicenseHeadertag is not allowed. Therefore it is removed when submitting an exception.