Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Conformance chapter #1002

Merged
merged 11 commits into from
Aug 10, 2024
Merged

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 24, 2024

From Bob's Word doc 2024-07-22 with few edits:

  • Translate links to a preferred format, with text labels
  • In Software Profile section, fix typo: "Conformance to the security profile" -> "Conformance to the Software Profile"
  • Recover corrupted text in section 5.12 using the same section from existing conformance.md (from v2.2.1, v2.3)

Notes

From Bob's Word doc 2024-07-22 with few edits:

- typos
- translate links to a preferred format
- recover corrupted text in section 5.12 using the same section from v2.2.2 Markdown file

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact mentioned this pull request Jul 25, 2024
70 tasks
- Also fix typo in Software Profile section: "Conformance to the security profile" -> "Conformance to the Software Profile"

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goneall goneall added this to the 3.0.1 milestone Aug 9, 2024
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together.

see:
[ECMA-404](https://ecma-international.org/publications-and-standards/standards/ecma-404/)
- The JSON Schema for SPDX can be found in the
[SPDX specification Git repository schemas directory](https://github.com/spdx/spdx-spec/blob/master/schemas/spdx-schema.json)
Copy link
Collaborator Author

@bact bact Aug 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bact - good catch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO Discuss: should we merge, then update? or wait for fix here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can find it quickly today, maybe wait.
If not, we can have another PR to fix that.

@kestewart kestewart merged commit ea69a8d into spdx:development/v3.0.1 Aug 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants