Add spdx3-validate to examples validation workflow #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also print validation setup (URLs and tool versions) Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Can be useful for debug during version updates Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
More quick clues for code readers Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
Validation failed due to individual-related issue. Turn to draft for now. |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
The validation script can run and print results as expected. |
goneall
approved these changes
Nov 19, 2024
|
It looks like the validation is failing - it also failed on a previous PR - so likely not do to these changes. @bact - if you find the source of the failure, can you include a fix in this PR? |
|
@goneall the validation fail is from the known issue of missing CreationInfo for individuals. We need to add it when generating the ontology file, with this PR spdx/spec-parser#154 or similar. |
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/check-examples.shto print relevant environment variables to assist debuggingsoftware_packageVersioninexamples/jsonld/package_sbom.jsonto match the version appears in thesoftware_downloadLocation