Address case sensitivity for license expressions #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit attempts to reflect the outcome of the discussion at spdx#63 regarding whether license expression operators and identifiers should be matched in a case-sensitive manner. Specifically it attempts to reflect the comment at spdx#63 (comment) regarding the outcome of the tech team discussion on 2018-06-05. Signed-off-by: Steve Winslow <steve@swinslow.net>
kestewart
approved these changes
Mar 24, 2020
goneall
requested changes
Mar 31, 2020
goneall
approved these changes
Mar 31, 2020
|
Flagging that tool providers may need to consider this, spdx tools has this implemented at this point. |
|
Thomas asked about license exception identifiers, Steve added clarity based. |
Signed-off-by: Steve Winslow <steve@swinslow.net>
|
closed in favor of #228 due to merge conflicts here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit attempts to reflect the outcome of the discussion at
#63 regarding whether
license expression operators and identifiers should be matched in
a case-sensitive manner.
Specifically it attempts to reflect the comment at
#63 (comment)
regarding the outcome of the tech team discussion on 2018-06-05.
Closes #63
@goneall -- would greatly appreciate your review, as I'm not certain whether I'm accurately capturing the intent of the comment linked above. Thanks!
Signed-off-by: Steve Winslow steve@swinslow.net