Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify encoding on file open #66

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Specify encoding on file open #66

merged 1 commit into from
Aug 14, 2023

Conversation

goneall
Copy link
Member

@goneall goneall commented Aug 12, 2023

This allows the spec-parser to be run on windows where the default encoding is not UTF-8.

Also updated the .gitignore to ignore any venv folders

This allows the spec-parser to be run on windows where the
default encoding is not UTF-8.

Also updated the .gitignore to ignore any venv folders

Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
@goneall goneall requested a review from zvr August 12, 2023 18:12
Copy link
Member

@zvr zvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really have non-ASCII input?

@goneall
Copy link
Member Author

goneall commented Aug 13, 2023

Do we really have non-ASCII input?

Apparently - I got an exception running spec-parser on Windows.

It tripped on spdx-3-model\model\Core\Properties\dataLicense.md

@zvr
Copy link
Member

zvr commented Aug 13, 2023

OK, I've created spdx/spdx-3-model#476 to fix this couple of quotes.

@goneall
Copy link
Member Author

goneall commented Aug 13, 2023

OK, I've created spdx/spdx-3-model#476 to fix this couple of quotes.

Reviewed it - we can merge it after a second review (even though I don't think anyone will complain if it was merged sooner)

Should we also merge this? Alternatively, we should document that you can only use ascii characters and verify it as part of the CI.

@zvr
Copy link
Member

zvr commented Aug 14, 2023

You know what I think: any time spent documenting spec parser is time lost of actually doing work on SPDX model and spec... So, it's faster to merge this one.

I did like the incidental fact that it was serving as a check about all-ASCII input, but I guess I can manually check once in a while.

@zvr zvr merged commit c1c645b into main Aug 14, 2023
@zvr zvr deleted the encoding branch August 14, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants