tagvalue parser incorrectly complains about DocumentComment

[justinabrahms]

Hello.

When parsing a tagvalue file, I incorrectly get the error received unknown tag DocumentComment in CreationInfo section. I've ensured the file passes validation at https://tools.spdx.org/app/validate/.

File listed here: eBay/sbom-scorecard#22 (comment)

Test case:

package main

import (
	"bytes"
	"fmt"
	"io/ioutil"

	spdx_tv "github.com/spdx/tools-golang/tvloader"
)

func main() {
	f, err := ioutil.ReadFile("/Users/jabrahms/Downloads/photon.spdxtv.txt")
	if err != nil {
		print("error opening SPDX document: %w", err)
		return
	}

	doc22, err := spdx_tv.Load2_2(bytes.NewReader(f))
	if err == nil && doc22 != nil {
		print("Found 2.2 tv document")
	} else {
		fmt.Println("Error: ", err)
	}
}

[neilnaveen]

@lumjjb I do not see tvloader package in main. It was their in the release v0.4.0, but now it is gone, how do you want to handle this?

[justinabrahms]

@neilnaveen I'm happy if you just fix what's in main.

package main

import (
	"bytes"
	"fmt"
	"io/ioutil"

	spdx_tv "github.com/spdx/tools-golang/tagvalue"
)

func main() {
	f, err := ioutil.ReadFile("/Users/jabrahms/Downloads/photon.spdxtv.txt")
	if err != nil {
		print("error opening SPDX document: %w", err)
		return
	}

	doc22, err := spdx_tv.Read(bytes.NewReader(f))
	if err == nil && doc22 != nil {
		print("Found 2.2 tv document")
	} else {
		fmt.Println("Error: ", err)
	}
}

and

$ go run main.go
Error:  received unknown tag DocumentComment in CreationInfo section

[neilnaveen]

Not in your code, but the main branch of spdx.

[justinabrahms]

@neilnaveen Totally. I (I think...?) updated the code to reflect the test case with what's in main.

[lumjjb]

@justinabrahms does the PR #185 from @neilnaveen fix this for you?

[justinabrahms]

@lumjjb It does;

go run main.go                                                          
Found 2.2 tv document% 

[lumjjb]

awesome closing this issue. Thanks @neilnaveen @justinabrahms