Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bug For DocumentComment #185

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

neilnaveen
Copy link
Contributor

addresses issue #182

  • added DocumentComment switch case for tag in parse_creation_info.go
  • added test for DocumentComment switch case
  • added file parse_document.go for the switch case above
  • added test for parse_document.go

Signed-off-by: Neil Naveen 42328488+neilnaveen@users.noreply.github.com

- added DocumentComment switch case for tag in parse_creation_info.go
- added test for DocumentComment switch case
- added file parse_document.go for the switch case above
- added test for parse_document.go

Signed-off-by: Neil Naveen <42328488+neilnaveen@users.noreply.github.com>
@neilnaveen neilnaveen force-pushed the neil/fix/parser_document/bug branch from fbe2f9b to ccf8e63 Compare January 26, 2023 17:40
Copy link
Collaborator

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @neilnaveen

Copy link
Collaborator

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should also be applied to spdx/v2/v2_3/tagvalue/... files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants