Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error string should not be capitalized or end with the punctuation mark #178

Closed
wants to merge 29 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
49d3576
Error string should not be capitalized or end with the punctuation mark
CatalinStratu Dec 30, 2022
7d9314e
Error string should not be capitalized or end with the punctuation mark
CatalinStratu Dec 30, 2022
c0fd445
Error string should not be capitalized or end with the punctuation mark
CatalinStratu Dec 30, 2022
fcc9894
Error string should not be capitalized or end with the punctuation mark
CatalinStratu Dec 30, 2022
acf3f0e
Error string should not be capitalized or end with the punctuation mark
CatalinStratu Dec 30, 2022
57d940a
Error string should not be capitalized or end with the punctuation mark
CatalinStratu Dec 30, 2022
c1e3ef3
Pipeline fix
CatalinStratu Dec 30, 2022
8fe1024
Pipeline fix
CatalinStratu Dec 30, 2022
1397c60
Pipeline fix
CatalinStratu Dec 30, 2022
ba43e84
Pipeline fix
CatalinStratu Dec 30, 2022
87d1e71
Pipeline fix
CatalinStratu Dec 30, 2022
e4072b1
Pipeline fix
CatalinStratu Dec 30, 2022
100743e
Pipeline fix
CatalinStratu Dec 30, 2022
0d64ef3
Pipeline fix
CatalinStratu Dec 30, 2022
aa5dffe
Error string should not be capitalized or end with the punctuation mark
CatalinStratu Dec 30, 2022
709905c
Pipeline fix
CatalinStratu Dec 30, 2022
e6c48e0
Pipeline fix
CatalinStratu Dec 30, 2022
1b2d241
Pipeline fix
CatalinStratu Dec 30, 2022
f3ee56b
Pipeline fix
CatalinStratu Dec 30, 2022
79a9033
Pipeline fix
CatalinStratu Dec 30, 2022
4964e3e
Pipeline fix
CatalinStratu Dec 30, 2022
e28d997
small fix
CatalinStratu Dec 30, 2022
fe8c286
Fix after code review
CatalinStratu Jan 2, 2023
b6d74b3
Fix after code review
CatalinStratu Jan 2, 2023
fd2ec40
Fix after code review
CatalinStratu Jan 2, 2023
639a8ba
Fix after code review
CatalinStratu Jan 2, 2023
d773abf
Fix after code review
CatalinStratu Jan 2, 2023
42b322c
Fix after code review
CatalinStratu Jan 2, 2023
d07521a
Fix after code review
CatalinStratu Jan 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/1-load/example_load.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ func main() {
filename := args[1]
r, err := os.Open(filename)
if err != nil {
fmt.Printf("Error while opening %v for reading: %v", filename, err)
fmt.Printf("error while opening %v for reading: %v", filename, err)
return
}
defer r.Close()

// try to load the SPDX file's contents as a tag-value file, version 2.2
doc, err := tvloader.Load2_2(r)
if err != nil {
fmt.Printf("Error while parsing %v: %v", filename, err)
fmt.Printf("error while parsing %v: %v", filename, err)
return
}

Expand All @@ -58,7 +58,7 @@ func main() {
// check whether the SPDX file has at least one package that it describes
pkgIDs, err := spdxlib.GetDescribedPackageIDs2_2(doc)
if err != nil {
fmt.Printf("Unable to get describe packages from SPDX document: %v\n", err)
fmt.Printf("unable to get describe packages from SPDX document: %v\n", err)
return
}

Expand Down
4 changes: 2 additions & 2 deletions examples/10-jsonloader/example_json_loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ func main() {
fileIn := args[1]
r, err := os.Open(fileIn)
if err != nil {
fmt.Printf("Error while opening %v for reading: %v", fileIn, err)
fmt.Printf("error while opening %v for reading: %v", fileIn, err)
return
}
defer r.Close()

// try to load the SPDX file's contents as a json file, version 2.2
doc, err := spdx_json.Load2_2(r)
if err != nil {
fmt.Printf("Error while parsing %v: %v", args[1], err)
fmt.Printf("error while parsing %v: %v", args[1], err)
return
}

Expand Down
8 changes: 4 additions & 4 deletions examples/11-yamltotv/exampleyamltotv.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ func main() {
fileIn := args[1]
r, err := os.Open(fileIn)
if err != nil {
fmt.Printf("Error while opening %v for reading: %v", fileIn, err)
fmt.Printf("error while opening %v for reading: %v", fileIn, err)
return
}
defer r.Close()

// try to load the SPDX file's contents as a YAML file
doc, err := spdx_yaml.Load2_2(r)
if err != nil {
fmt.Printf("Error while parsing %v: %v", fileIn, err)
fmt.Printf("error while parsing %v: %v", fileIn, err)
return
}

Expand All @@ -52,15 +52,15 @@ func main() {
fileOut := args[2]
w, err := os.Create(fileOut)
if err != nil {
fmt.Printf("Error while opening %v for writing: %v", fileOut, err)
fmt.Printf("error while opening %v for writing: %v", fileOut, err)
return
}
defer w.Close()

// try to save the document to disk as an SPDX tag-value file, version 2.2
err = tvsaver.Save2_2(doc, w)
if err != nil {
fmt.Printf("Error while saving %v: %v", fileOut, err)
fmt.Printf("error while saving %v: %v", fileOut, err)
return
}

Expand Down
8 changes: 4 additions & 4 deletions examples/12-tvtoyaml/exampletvtoyaml.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ func main() {
fileIn := args[1]
r, err := os.Open(fileIn)
if err != nil {
fmt.Printf("Error while opening %v for reading: %v", fileIn, err)
fmt.Printf("error while opening %v for reading: %v", fileIn, err)
return
}
defer r.Close()

// try to load the SPDX file's contents as a tag-value file, version 2.2
doc, err := tvloader.Load2_2(r)
if err != nil {
fmt.Printf("Error while parsing %v: %v", args[1], err)
fmt.Printf("error while parsing %v: %v", args[1], err)
return
}

Expand All @@ -51,15 +51,15 @@ func main() {
fileOut := args[2]
w, err := os.Create(fileOut)
if err != nil {
fmt.Printf("Error while opening %v for writing: %v", fileOut, err)
fmt.Printf("error while opening %v for writing: %v", fileOut, err)
return
}
defer w.Close()

// try to save the document to disk as an YAML file
err = spdx_yaml.Save2_2(doc, w)
if err != nil {
fmt.Printf("Error while saving %v: %v", fileOut, err)
fmt.Printf("error while saving %v: %v", fileOut, err)
return
}

Expand Down
4 changes: 2 additions & 2 deletions examples/13-yamlloader/exampleYAMLLoader.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ func main() {
fileIn := args[1]
r, err := os.Open(fileIn)
if err != nil {
fmt.Printf("Error while opening %v for reading: %v", fileIn, err)
fmt.Printf("error while opening %v for reading: %v", fileIn, err)
return
}
defer r.Close()

// try to load the SPDX file's contents as a json file, version 2.2
doc, err := spdx_yaml.Load2_2(r)
if err != nil {
fmt.Printf("Error while parsing %v: %v", args[1], err)
fmt.Printf("error while parsing %v: %v", args[1], err)
return
}

Expand Down
8 changes: 4 additions & 4 deletions examples/2-load-save/example_load_save.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ func main() {
fileIn := args[1]
r, err := os.Open(fileIn)
if err != nil {
fmt.Printf("Error while opening %v for reading: %v", fileIn, err)
fmt.Printf("error while opening %v for reading: %v", fileIn, err)
return
}
defer r.Close()

// try to load the SPDX file's contents as a tag-value file, version 2.2
doc, err := tvloader.Load2_2(r)
if err != nil {
fmt.Printf("Error while parsing %v: %v", fileIn, err)
fmt.Printf("error while parsing %v: %v", fileIn, err)
return
}

Expand All @@ -52,15 +52,15 @@ func main() {
fileOut := args[2]
w, err := os.Create(fileOut)
if err != nil {
fmt.Printf("Error while opening %v for writing: %v", fileOut, err)
fmt.Printf("error while opening %v for writing: %v", fileOut, err)
return
}
defer w.Close()

// try to save the document to disk as an SPDX tag-value file, version 2.2
err = tvsaver.Save2_2(doc, w)
if err != nil {
fmt.Printf("Error while saving %v: %v", fileOut, err)
fmt.Printf("error while saving %v: %v", fileOut, err)
return
}

Expand Down
6 changes: 3 additions & 3 deletions examples/3-build/example_build.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func main() {
// - the config object we just defined.
doc, err := builder.Build2_2(packageName, packageRootDir, config)
if err != nil {
fmt.Printf("Error while building document: %v\n", err)
fmt.Printf("error while building document: %v\n", err)
return
}

Expand All @@ -103,14 +103,14 @@ func main() {
// create a new file for writing
w, err := os.Create(fileOut)
if err != nil {
fmt.Printf("Error while opening %v for writing: %v\n", fileOut, err)
fmt.Printf("error while opening %v for writing: %v\n", fileOut, err)
return
}
defer w.Close()

err = tvsaver.Save2_2(doc, w)
if err != nil {
fmt.Printf("Error while saving %v: %v", fileOut, err)
fmt.Printf("error while saving %v: %v", fileOut, err)
return
}

Expand Down
8 changes: 4 additions & 4 deletions examples/9-tvtojson/exampletvtojson.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ func main() {
fileIn := args[1]
r, err := os.Open(fileIn)
if err != nil {
fmt.Printf("Error while opening %v for reading: %v", fileIn, err)
fmt.Printf("error while opening %v for reading: %v", fileIn, err)
return
}
defer r.Close()

// try to load the SPDX file's contents as a tag-value file, version 2.2
doc, err := tvloader.Load2_2(r)
if err != nil {
fmt.Printf("Error while parsing %v: %v", args[1], err)
fmt.Printf("error while parsing %v: %v", args[1], err)
return
}

Expand All @@ -51,15 +51,15 @@ func main() {
fileOut := args[2]
w, err := os.Create(fileOut)
if err != nil {
fmt.Printf("Error while opening %v for writing: %v", fileOut, err)
fmt.Printf("error while opening %v for writing: %v", fileOut, err)
return
}
defer w.Close()

// try to save the document to disk as JSON file
err = spdx_json.Save2_2(doc, w)
if err != nil {
fmt.Printf("Error while saving %v: %v", fileOut, err)
fmt.Printf("error while saving %v: %v", fileOut, err)
return
}

Expand Down
4 changes: 2 additions & 2 deletions json/json_v2_2_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ func TestLoad2_2(t *testing.T) {
handwrittenExample := want2_2

if cmp.Equal(handwrittenExample, got) {
t.Errorf("Got incorrect struct after parsing JSON example")
t.Errorf("got incorrect struct after parsing JSON example")
return
}
}
Expand All @@ -52,7 +52,7 @@ func TestWrite2_2(t *testing.T) {
}

if cmp.Equal(handwrittenExample, parsedDoc) {
t.Errorf("Got incorrect struct after writing and re-parsing JSON example")
t.Errorf("got incorrect struct after writing and re-parsing JSON example")
return
}
}
Expand Down
4 changes: 2 additions & 2 deletions json/json_v2_3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func TestLoad2_3(t *testing.T) {
handwrittenExample := want2_3

if cmp.Equal(handwrittenExample, got) {
t.Errorf("Got incorrect struct after parsing JSON example")
t.Errorf("got incorrect struct after parsing JSON example")
return
}
}
Expand All @@ -69,7 +69,7 @@ func TestWrite2_3(t *testing.T) {
}

if cmp.Equal(handwrittenExample, parsedDoc) {
t.Errorf("Got incorrect struct after writing and re-parsing JSON example")
t.Errorf("got incorrect struct after writing and re-parsing JSON example")
return
}
}
Expand Down
Loading