Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Update docs for 0.4.0 release #179

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Conversation

lumjjb
Copy link
Collaborator

@lumjjb lumjjb commented Jan 11, 2023

Create release notes for v0.4.0

Signed-off-by: Brandon Lum lumjjb@gmail.com

@swinslow
Copy link
Member

Hi @lumjjb, this mostly looks good to me! I have just two comments:

  • For updated constants #163, this is listed as being part of enabling YAML support. Is that correct, or was updated constants #163 adding new constants for a different purpose? (I wasn't involved in adding the YAML support, so definitely defer to you and others on this.)
  • In looking at this, it occurred to me that the README statement about "no requirements other than gordf" is no longer accurate. I just submitted docs: Remove outdated statement about requirements #180 to remove this statement, since it's probably worth fixing that for the release-tagged version.

Other than those, I'm good to give the +1 here. Thanks!

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb
Copy link
Collaborator Author

lumjjb commented Jan 11, 2023

ahh you're right it was meant for the next line, fixed! Also merged your PR!

@lumjjb
Copy link
Collaborator Author

lumjjb commented Jan 12, 2023

resolved the comments so merging this.

@lumjjb lumjjb merged commit 843bc98 into spdx:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants