fix(2.2 json): remove emtpy packageVerificationCode #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2023
Merged
lumjjb
reviewed
Sep 22, 2023
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
force-pushed
the
fix/omit-empty-package-verification-code-2-2
branch
from
6d25b5b to
1eeb39c
Compare
Signed-off-by: Keith Zantow <kzantow@gmail.com>
willmurphyscode
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
LGTM. Thanks for finding a specific link to the spec @kzantow
cuixq
referenced
this pull request
in google/osv-scanner
Apr 17, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [deps.dev/api/v3](https://togithub.com/google/deps.dev) | require | digest | `2c48bd5` -> `f6f382d` | | | | | | [deps.dev/util/maven](https://togithub.com/google/deps.dev) | require | digest | `2c48bd5` -> `f6f382d` | | | | | | [deps.dev/util/resolve](https://togithub.com/google/deps.dev) | require | digest | `2c48bd5` -> `f6f382d` | | | | | | [deps.dev/util/semver](https://togithub.com/google/deps.dev) | require | digest | `2c48bd5` -> `f6f382d` | | | | | | [github.com/spdx/tools-golang](https://togithub.com/spdx/tools-golang) | require | patch | `v0.5.3` -> `v0.5.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | golang.org/x/exp | require | digest | `93d18d7` -> `fe59bbe` | | | | | --- ### Release Notes <details> <summary>spdx/tools-golang (github.com/spdx/tools-golang)</summary> ### [`v0.5.4`](https://togithub.com/spdx/tools-golang/releases/tag/v0.5.4) [Compare Source](https://togithub.com/spdx/tools-golang/compare/v0.5.3...v0.5.4) ##### What's Changed - Stop escaping HTML by [@​kzantow](https://togithub.com/kzantow) in [https://github.com/spdx/tools-golang/pull/224](https://togithub.com/spdx/tools-golang/pull/224) - Don't create empty `ExcludedFiles` array by [@​DmitriyLewen](https://togithub.com/DmitriyLewen) in [https://github.com/spdx/tools-golang/pull/230](https://togithub.com/spdx/tools-golang/pull/230) - Add external reference category `OTHER` by [@​mcombuechen](https://togithub.com/mcombuechen) in [https://github.com/spdx/tools-golang/pull/229](https://togithub.com/spdx/tools-golang/pull/229) - Remove empty packageVerificationCode in 2.2 JSON by [@​kzantow](https://togithub.com/kzantow) in [https://github.com/spdx/tools-golang/pull/223](https://togithub.com/spdx/tools-golang/pull/223) ##### New Contributors - [@​mcombuechen](https://togithub.com/mcombuechen) made their first contribution in [https://github.com/spdx/tools-golang/pull/229](https://togithub.com/spdx/tools-golang/pull/229) **Full Changelog**: spdx/tools-golang@v0.5.3...v0.5.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on monday" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SPDX 2.2, the
packageVerificationCodeelement is optional, but the Go struct does not allow this to be omitted. This was corrected by changing the type to a pointer in SPDX 2.3, but still is an issue in SPDX 2.2. In the casefilesAnalyzedisfalse, it is required to omit this field. This PR implements a simple method to remove emtpypackageVerificationCodeentries in SPDX 2.2, specifically.