Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files have no SPDX-License-Identifier #511

Closed
vargenau opened this issue Mar 7, 2023 · 4 comments · Fixed by #512 or #548
Closed

Files have no SPDX-License-Identifier #511

vargenau opened this issue Mar 7, 2023 · 4 comments · Fixed by #512 or #548

Comments

@vargenau
Copy link
Contributor

vargenau commented Mar 7, 2023

Let us use our own specification :-)
vargenau added a commit to vargenau/tools-python that referenced this issue Mar 7, 2023
@vargenau
Adding SPDX-License-Identifier in source code files.
4f9c9b2 
Fix spdx#511

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
@vargenau vargenau mentioned this issue Mar 7, 2023
Merged
armintaenzertng pushed a commit to vargenau/tools-python that referenced this issue Mar 9, 2023
@vargenau @armintaenzertng
Adding SPDX-License-Identifier in source code files.
aa982d9 
Fix spdx#511

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
armintaenzertng pushed a commit that referenced this issue Mar 10, 2023
@vargenau @armintaenzertng
Adding SPDX-License-Identifier in source code files.
b0d946b 
Fix #511

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
@armintaenzertng
Copy link
Collaborator

Reopening this as we should also apply this to the refactored branch.

@HarshvMahawar
Copy link
Contributor

what exactly needs to be done in this issue, can you please elaborate, thanks :)

@vargenau
Copy link
Contributor Author

See pull request #512
It was done on the current code.
As stated above, ticket is still open as the same must be applied to the refactored branch.

@armintaenzertng
Copy link
Collaborator

We plan to completely replace the license text with the license identifier in the refactored branch.
The way I understand it, removing a license text this way is only possible by the creators of the files, so it can't be done by you, @HarshvMahawar, sorry.

@armintaenzertng armintaenzertng mentioned this issue Mar 30, 2023
Merged
@meretp meretp mentioned this issue Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vargenau @armintaenzertng @HarshvMahawar