Add support for parsing complex license expressions #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierfigueroav
force-pushed
the
license-expressions
branch
from
2d1a306 to
7be0d04
Compare
|
@xavierfigueroav ping.... do you thing this could be rebased? |
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
Signed-off-by: Xavier Figueroa <xavierfigueroav@gmail.com>
xavierfigueroav
force-pushed
the
license-expressions
branch
from
7be0d04 to
3f32e32
Compare
Hi, PhiIippe :) I've rebased the code. |
The existing example for write_tv requires a couple of fields in the Document, Package and File objects that are not defined. This causes the example to fail, which makes its goal of being a reference for current implementors
The current version of the example fails with "Document is Invalid" errors, which makes it rather hard to understand what is invalid about the document. Further, the exception caught itself presents is already floating information about which checks specifically made the document invalid. Present this information to the user in such a way that they can identify and fix the errors in their document
Signed-off-by: Shubham Kumar Jha <skjha832@gmail.com>
Signed-off-by: Shubham Kumar Jha <skjha832@gmail.com>
Fixes the install error in Python 2.7 and CircleCI error with Python 3.4.8
Previously, there was an extra '>' in line 42 which was the reason this rdf/xml file was showing error. Now, the file is validated. Signed-off-by: Yash Varshney <b18038@students.iitmandi.ac.in>
Validated the RDF file
…sh Varshney as a part of CommunityBridgeMentorship Programme. The main feature introduce is the CLI-tool for python parser and convertor. Apart from this, Relationship Class is added in python tool, all the other classes have been updated wrt to v2.2 of spdx specs (some issues have also been raised), attribution text has been added to file,package and snippet class as well. BLACK is used for formatting the whole tool. Signed-off-by: Yash Varshney <b18038@students.iitmandi.ac.in>
CommunityBridge Project by Yash Varshney
It was deprecated in Python 3.1 and removed in Python 3.9.
Fix typo Merging after all. A one character change is not material Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Click dropped support for all 2.x versions and all 3.5 or earlier versions of Python. So, in order to support those versions, we must tie the click version to click 7.x. Since we're still actively testing these older Python versions in CI, this should fix a number of issues in CI. Fixes spdx#161. Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Fixes spdx#163. Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Fixes spdx#165. Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Do not test old Pythons in CI Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
test_jsonyamlxml_parser: remove deprecated json.load encoding argument Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Update CircleCI xcode version to a supported one. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Drop Python 2.7 and 32-bit testing on Appveyor. Use instead Python 3.6 to 3.9 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Support multiple packages per SPDX document. This set of patches adds support for multiple packages per document, by adding document.packages as an array. The API for managing multiple packages is set up to mimic the other APIs for managing multiple objects (files, external licenses, etc.). To preserve backwards compatibility, this patch introduces document.package as a property; this property is implemented using document.packages behind the scenes, and triggers a DeprecationWarning. Support is included for parsing documents with multiple packages, as well as writing such documents. Fixes spdx#79. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
…#149 Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: alpianon <alberto@pianon.eu>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com> Co-authored-by: alpianon <alberto@pianon.eu> Signed-off-by: alpianon <alberto@pianon.eu>
spdx#133 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
spdx#111 Signed-off-by: Philippe Ombredanne <pombredanne@gmail.com>
spdx#111 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
I am keeping this around as this will eventually be merged. |
|
@pombredanne, is this still valid? Do you know when the "eventually" you mentioned might be? As this PR is quite massive, it will cause a lot of conflicts in the future. |
|
@armintaenzertng your call. Parsing expression is a must have IMHO. |
|
I'd like to see a rebase of this PR to get a better sense of what actually changed as the multiple merge commits make this rather incomprehensible. @xavierfigueroav, are you willing to do this? Else I'll gladly take over from here :) |
|
Looking at the size, age and type of changes in this PR, I think the only viable course of action is to start from scratch based on current I will wait for a few days to see if anyone disagrees, then close this. The corresponding issue is #10 |
|
Closing this as announced earlier. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of the license-expression library to parse complex license expressions in SPDX documents.
Signed-off-by: Xavier Figueroa xavierfigueroav@gmail.com