[issue-487] add tests for the document_utils.py module
#533
Conversation
tests/spdx/test_document_utils.py
Outdated
| @@ -0,0 +1,27 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2023 spdx contributors | |||
There was a problem hiding this comment.
Not sure if this is valid, I would understand the specification to either use Copyright (c) .. or SPDX-FileCopyrightText: 2023... The suggested change would align with the header in test_creation_info_writer.py.
| # SPDX-FileCopyrightText: Copyright (c) 2023 spdx contributors | |
| # SPDX-FileCopyrightText: 2023 spdx contributors |
There was a problem hiding this comment.
changed and adapted my copyright profile (again^^)
| document, package, file, snippet = variables | ||
| assert get_element_from_spdx_id(document, package.spdx_id) == package | ||
| assert get_element_from_spdx_id(document, file.spdx_id) == file | ||
| assert get_element_from_spdx_id(document, snippet.spdx_id) == snippet |
There was a problem hiding this comment.
What happens if there is no matching element?
There was a problem hiding this comment.
should return None, I will add this
| def test_contained_element_ids(variables): | ||
| document, package, file, snippet = variables | ||
| element_ids = get_contained_spdx_element_ids(document) | ||
| TestCase().assertCountEqual(element_ids, [package.spdx_id, file.spdx_id, snippet.spdx_id]) |
There was a problem hiding this comment.
Maybe also check that no other element is contained? The test relies on the fact that document_fixture only contains the respective elements from the fixtures.
There was a problem hiding this comment.
assertCountEqual() already tests that there exactly the same elements (with multiplicity) in the lists
There was a problem hiding this comment.
ahh, true, my brain is still on vacation :D
Signed-off-by: Armin Tänzer <armin.taenzer@tngtech.com>
armintaenzertng
force-pushed
the
addTestDocumentUtils
branch
from
6fbe644 to
042e7c7
Compare
fixes #487