[issue-586] fix CLI #588
Merged
[issue-586] fix CLI #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armintaenzertng
previously approved these changes
Apr 17, 2023
tests/spdx/test_cli.py
Outdated
| ("-i", os.path.join(os.path.dirname(__file__), "data/SPDXJSONExample-v2.3.spdx.json"), "-o", "-"), | ||
| ], | ||
| ) | ||
| def test_cli(options: Tuple[str, str]): |
There was a problem hiding this comment.
I'm not sure about this type hint, as there are different numbers of strings in the passed tuples. In the test below there is no type hint, either, so maybe just omit it...?
There was a problem hiding this comment.
Yeah sure, that was a blind copy and paste mistake
meretp
force-pushed
the
fix-cli
branch
3 times, most recently
from
290497c to
e56ba7b
Compare
tests/spdx/test_cli.py
Outdated
| ("-i", os.path.join(os.path.dirname(__file__), "data/SPDXJSONExample-v2.3.spdx.json"), "-o"), | ||
| ], | ||
| ) | ||
| def test_cli_with_system_exit(options): |
There was a problem hiding this comment.
Sorry, one other thing; every CLI call has a system exit, the important part here is the exit code:
Suggested change
| def test_cli_with_system_exit(options): | |
| def test_cli_with_system_exit_code_2(options): |
There was a problem hiding this comment.
maybe also adapt the other test name to be consistent
meretp
force-pushed
the
fix-cli
branch
2 times, most recently
from
fcceed9 to
e9886ae
Compare
… when no arguments are given Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
armintaenzertng
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we make infile a required argument to display a help message when no arguments are given.
I also added some test to check that the cli fails for invalid arguments and passes for correct arguments.
fixes #586