[issue-649] fix TV-parser #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meretp
force-pushed
the
issue_649_fix_tv_parser
branch
from
ba9fd6c to
7936a62
Compare
armintaenzertng
previously approved these changes
May 12, 2023
| ] | ||
| ) | ||
| with pytest.raises(SPDXParsingError) as err: | ||
| _ = parser.parse(document_str) |
There was a problem hiding this comment.
Suggested change
| _ = parser.parse(document_str) | |
| parser.parse(document_str) |
Assignments are not mandatory.
There was a problem hiding this comment.
fixed and force-pushed, so I need another approval 😇
…ue to a non-parseable preceding package Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
issue_649_fix_tv_parser
branch
from
7936a62 to
c2f85ee
Compare
armintaenzertng
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we log an error if the build of a contains relationship fails due to a non-parseable preceding package.
fixes #649