[issue-650] raise ParsingError if elements don't have an SPDXID #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -140,7 +140,7 @@ def get_value_from_graph( | |||
| # this is a helper method to cast some rdf types from graph.value() to be compatible with the | |||
| # code that follows | |||
| value = graph.value(subject=subject, predicate=predicate, object=_object, default=default, any=_any) | |||
| if value and not isinstance(value, (URIRef, Literal, BNode)): | |||
| if value != _any and value and not isinstance(value, (URIRef, Literal, BNode)): | |||
There was a problem hiding this comment.
I don't get the value != _any part here. _any is a bool, why should it be equal to value?
There was a problem hiding this comment.
Yeah, sorry, mixed the values here. This needs to be value != default. While working on this I noticed that an error about wrong types would be logged if a package has no files_analyzed field. This is as the changes you commented below not related to the origin issue and rather a fix for the wrapper methods introduced with #563. Shall I create a separate PR for these changes?
There was a problem hiding this comment.
Yes, please do :)
There was a problem hiding this comment.
#653
The PR should be merged first as the test in this PR fails without these changes.
meretp
force-pushed
the
issue_650_fix_rdf_parser
branch
from
492af03 to
ecdd0d1
Compare
Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
issue_650_fix_rdf_parser
branch
from
ecdd0d1 to
0f41ee0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #650