Update typeguard #657
Closed
Update typeguard #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [typeguard](https://github.com/agronholm/typeguard) from 2.13.3 to 4.0.0. - [Changelog](https://github.com/agronholm/typeguard/blob/master/docs/versionhistory.rst) - [Commits](agronholm/typeguard@2.13.3...4.0.0) --- updated-dependencies: - dependency-name: typeguard dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
meretp
force-pushed
the
update-typeguard
branch
2 times, most recently
from
c67b294 to
c42fc1b
Compare
- the error raised is a `TypeCheckError` - we need to enable the CollectionCheckStrategy.ALL_ITEMS to check each instance in a collection - instead of checking the generated error messages for each class we only check that an error is raised for every class and use only one invalid package as a proxy for all other tests to check the generated message Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #655
The following adaptions were made to be able to bump typeguard from 2.13.3 to 4.0.0
TypeCheckErrorThe generated error message changed with the update. In the
test_error_messagemodule you can see an example for the new message. I think the part forpackage.download_location(so a wrong type where aUnionof types is possible) takes a bit of getting used to, but in my opinion the problem becomes clear and we don't need to customize this error.