Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow URLs with capital letters #833

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow URLs with capital letters #833

wants to merge 1 commit into from

Conversation

CsatariGergely
Copy link

Fixes: #832

@CsatariGergely
Allow URLs with capital letters
67af1af 
Signed-off-by: Gergely Csatari <gergely.csatari@nokia.com>
@CsatariGergely
Copy link
Author

The Java validator allows URLs with capitals.

@armintaenzertng
Copy link
Collaborator

Thanks for catching and fixing this!

Would you mind adding appropriate test cases to the test_valid_url test to document this behavior?

@CsatariGergely
Copy link
Author

Humm, I would need some help with the testing @armintaenzertng . It looks like if I run pytest in my dev branch it is not running my modified code. I did pip3 install the local folder before, but still it seems that my changes are not running. Can you help me to figure this out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URLs with capital letters fail on the URL check
2 participants
@CsatariGergely @armintaenzertng