Don't automatically send push response headers if disabled #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default a push stream created via
Stream#pushPromise()
willimmediately send the response headers (the ones provided or a default one
with only the status code).
This commit allows to conditionally skip sending those headers at
Stream
creation by explicitly setting theresponse
property tofalse
.Thus allowing the headers to be manually sent at a later point via
Stream#respond()
.This modification also solves a significant part of my
node-spdy
issue spdy-http2/node-spdy#323.The push related part of the documentation of
node-spdy
, should probably also be updated with something like: