Skip to content

Commit

Permalink
fix reference resolution for examples
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Grossmann-Kavanagh committed Jul 13, 2018
1 parent 16508eb commit 2e4ba0c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
5 changes: 3 additions & 2 deletions connexion/operations/openapi.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ def component_get(oas3_name):
self._definitions_map = {
'components': {
'schemas': component_get('schemas'),
'examples': component_get('examples'),
'requestBodies': component_get('requestBodies'),
'parameters': component_get('parameters'),
'securitySchemes': component_get('securitySchemes'),
Expand Down Expand Up @@ -126,8 +127,8 @@ def resolve_responses(responses):
for mimetype, resp in content.items():
# check components/examples
examples = resp.get("examples", {})
for _, example in examples.items():
example = self._resolve_reference(example)
examples = {k: self._resolve_reference(v)
for k, v in examples.items()}

example = resp.get("example", {})
ref = self._resolve_reference(example)
Expand Down
7 changes: 5 additions & 2 deletions tests/fixtures/simple/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -543,8 +543,7 @@ paths:
type: string
examples:
justAnExample:
summary: a basic example.
value: Good evening, doctor.
$ref: '#/components/examples/justAnExample'
parameters:
- name: name
in: path
Expand Down Expand Up @@ -852,6 +851,10 @@ components:
type: string
description: Just a testing parameter in the body
required: true
examples:
justAnExample:
summary: a basic example.
value: Good evening, doctor.
schemas:
new_stack:
type: object
Expand Down

0 comments on commit 2e4ba0c

Please sign in to comment.