Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved error 415 #1185

Merged
merged 3 commits into from
Nov 4, 2021
Merged

improved error 415 #1185

merged 3 commits into from
Nov 4, 2021

Conversation

parthsujalshah
Copy link
Contributor

@parthsujalshah parthsujalshah commented Mar 20, 2020 •
edited by Ruwann
Loading

As per the issue #1181 , the 415 response now is improved!

@coveralls
Copy link

coveralls commented Mar 20, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 97.02% when pulling ed464b0 on parthsujalshah:error-415 into f45ef0e on zalando:main.

@hjacobs
Copy link
Contributor

hjacobs commented Apr 4, 2020

Can you add a test for this change?

@parthsujalshah
Copy link
Contributor Author

I have added the test

@parthsujalshah
Copy link
Contributor Author

What do I need to add in swagger.yaml and openapi.yaml files for erro 415?

@hjacobs
Copy link
Contributor

hjacobs commented Apr 25, 2020

The Travis build is currently failing: https://travis-ci.org/github/zalando/connexion/builds/671478075

@Ruwann Ruwann changed the base branch from master to main July 20, 2021 15:39
@Ruwann Ruwann self-requested a review July 20, 2021 15:53
@Ruwann
Copy link
Member

Ruwann commented Jul 20, 2021

@hjacobs I fixed the failing tests/build, so I think this one can be merged now. WDYT?

@Ruwann Ruwann merged commit fc6803b into spec-first:main Nov 4, 2021
@Ruwann Ruwann mentioned this pull request Nov 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruwann Ruwann Ruwann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parthsujalshah @coveralls @hjacobs @Ruwann