Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 in favor of 3.6 #1494

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Add Python 3.10 in favor of 3.6 #1494

merged 2 commits into from
Mar 28, 2022

Conversation

RobbeSneyders
Copy link
Member

Fixes #1493

@RobbeSneyders RobbeSneyders added this to the Connexion 3.0 milestone Mar 17, 2022
@RobbeSneyders RobbeSneyders requested a review from Ruwann March 17, 2022 22:16
@RobbeSneyders RobbeSneyders changed the base branch from feature/drop-aiohttp to feature/connexion-middleware March 18, 2022 13:44
@RobbeSneyders RobbeSneyders changed the base branch from feature/connexion-middleware to feature/drop-aiohttp March 18, 2022 13:46
Base automatically changed from feature/drop-aiohttp to main March 22, 2022 21:26
@Ruwann
Copy link
Member

Ruwann commented Mar 24, 2022

This PR still has the aiohttp changes in it - not sure why it's still showing in the diff though. Can you remove the Drop aiohttp commit from this PR?

@RobbeSneyders
Copy link
Member Author

Done

@RobbeSneyders
Copy link
Member Author

The tests are failing due to Flask dependency conflicts. I fixed it in #1502, which is a PR on top of this one, and you can see the tests passing.

I it's OK for you, I would propose to merge both after reviewing together, so I don't need to move the fix to this PR.

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Merging both sounds good to me :)

@RobbeSneyders RobbeSneyders merged commit 9d3155f into main Mar 28, 2022
@RobbeSneyders RobbeSneyders deleted the feature/python3.10 branch March 28, 2022 21:54
vmarkovtsev pushed a commit to athenianco/especifico that referenced this pull request Mar 31, 2022
* Add Python 3.10 in favor of 3.6

* Increase lower bound requests for Python 3.10 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.10 in favor of 3.6
2 participants