Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for changed werkzeug behavior in 2.1 #1506

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

RobbeSneyders
Copy link
Member

Cherry picks the fix for werkzeug 2.1 from main for our v2 branch.

pallets/werkzeug#2352.

@RobbeSneyders RobbeSneyders added this to the Connexion 2.x milestone Apr 1, 2022
@RobbeSneyders RobbeSneyders requested a review from Ruwann April 1, 2022 15:55
vmarkovtsev added a commit to athenianco/especifico that referenced this pull request Apr 3, 2022
vmarkovtsev added a commit to athenianco/especifico that referenced this pull request Apr 3, 2022
vmarkovtsev added a commit to athenianco/especifico that referenced this pull request Apr 3, 2022
vmarkovtsev added a commit to athenianco/especifico that referenced this pull request Apr 3, 2022
vmarkovtsev added a commit to athenianco/especifico that referenced this pull request Apr 3, 2022
Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ruwann Ruwann merged commit ea45242 into v2 Apr 4, 2022
@Ruwann Ruwann deleted the bugfix/werkzeug-2.1 branch April 4, 2022 16:52
RobbeSneyders added a commit that referenced this pull request May 4, 2022
* Fix uri parsing for query parameter with empty brackets (#1501)

* Update tests for changed werkzeug behavior in 2.1 (#1506)

pallets/werkzeug#2352

* Bugfix/async security check (#1512)

* Add failing tests

* Use for else construct

* openapi: remove JSON body second validation and type casting (#1170)

* openapi: remove body preprocessing

Body is already validated using jsonschema. There was also some type
casting but it was wrong: e.g. not recurring deeply into dicts and lists,
relying on existence of "type" in schema (which is not there e.g. if
oneOf is used). Anyway, the only reason why types should be casted is
converting integer values to float if the type is number. But this is in
most cases irrelevant.

Added an example, which did not work before this commit (echoed `{}`)
e.g. for
```
curl localhost:8080/api/foo -H 'content-type: application/json' -d
'{"foo": 1}'
```
but now the example works (echoes `{"foo": 1}`).

* test with oneOf in the requestBody

* remove oneof examples: superseded by tests

Co-authored-by: Pavol Vargovcik <pavol.vargovcik@kiwi.com>

Co-authored-by: Ruwann <ruwanlambrichts@gmail.com>
Co-authored-by: Pavol Vargovčík <pavol.vargovcik@gmail.com>
Co-authored-by: Pavol Vargovcik <pavol.vargovcik@kiwi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants