Add pre-commit hook #1511
Merged
Add pre-commit hook #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
force-pushed
the
feature/pre-commit
branch
from
bcce5a8 to
437d984
Compare
Pull Request Test Coverage Report for Build 2157241108
💛 - Coveralls |
|
👍 |
RobbeSneyders
commented
Apr 12, 2022
| @@ -39,10 +39,9 @@ def read_version(package): | |||
| ] | |||
|
|
|||
| tests_require = [ | |||
| 'decorator>=5,<6', | |||
There was a problem hiding this comment.
Doesn't seem to be used.
| 'pytest-cov>=2,<3', | ||
| 'testfixtures>=6,<7', |
There was a problem hiding this comment.
Doesn't seem to be used.
| @@ -92,7 +91,6 @@ def readme(): | |||
| url='https://github.com/zalando/connexion', | |||
| keywords='openapi oai swagger rest api oauth flask microservice framework', | |||
| license='Apache License Version 2.0', | |||
| setup_requires=['flake8'], | |||
There was a problem hiding this comment.
No longer needed here since we don't run flake8 via setup.py anymore.
Ruwann
approved these changes
Apr 12, 2022
RobbeSneyders
force-pushed
the
feature/pre-commit
branch
from
437d984 to
b3cbd96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-commit hook which runs the static analysis checks on the changed code before committing. The hook is reused by tox so the steps only need to be defined once.
This is a prerequisite for #1498.