Respect what the APIs consume #289
Conversation
| @@ -125,6 +125,10 @@ def __init__(self, swagger_yaml_path, base_url=None, arguments=None, | |||
| # API calls. | |||
| self.produces = self.specification.get('produces', list()) # type: List[str] | |||
|
|
|||
| # A list of MIME types the APIs can consume. This is global to all APIs but can be overridden on specific | |||
| # API calls. | |||
There was a problem hiding this comment.
Please lets not duplicate comments.
There was a problem hiding this comment.
Sorry, what exactly do you mean? The comment relates to the consumes param yet it's almost similar to the produces. Should I rewrite it somehow or just remove?
|
@31z4 Thanks for you PR. Could you please write at least one test covering this issue? |
|
@rafaelcaricio of course. Will do this a bit later as well as fix the emerged failures. |
| @@ -114,6 +116,9 @@ def __call__(self, function): | |||
|
|
|||
| @functools.wraps(function) | |||
| def wrapper(*args, **kwargs): | |||
| if 'application/json' not in self.consumes: | |||
| return function(*args, **kwargs) | |||
There was a problem hiding this comment.
Is this necessary? We should have a test that covers this scenario.
There was a problem hiding this comment.
Yes it is. Without it validation fails on the plain text request. Added a test.
| request_body = flask.request.json | ||
| except exceptions.BadRequest: | ||
| request_body = None | ||
| if 'application/json' in consumes: |
There was a problem hiding this comment.
This is not the right check. There are lots of "+json" mimetypes that have to be parsed as json
There was a problem hiding this comment.
You should use is_json_mimetype for this check.
| @@ -114,6 +116,9 @@ def __call__(self, function): | |||
|
|
|||
| @functools.wraps(function) | |||
| def wrapper(*args, **kwargs): | |||
| if 'application/json' not in self.consumes: | |||
There was a problem hiding this comment.
Again the wrong check. And I would put the validation logic inside the if to avoid repeating function(*args, **kwargs)
|
@jmcs Thanks for your feedback! |
|
👍 |
Fixes #287.
Changes proposed in this pull request:
application/jsonis not listed in theconsumesthen don't parse and validate the request body.