Fix KeyError if no Content-Type was provided in request

[f11r]

At the moment if no Content-Type is provided in the request the validation wrapper raises a KeyError.

Can we expect a fix to make it into a release soon or should we look for a temporary workaround until that happens?

[coveralls]

Coverage remained the same at 100.0% when pulling 26031bc on f11r:master into d51e9c8 on zalando:master.

[hjacobs]

@f11r looks good, thanks for the PR! Could you add a test for this case please? Thanks!

[hjacobs]

@f11r answering your question: yes, we can quickly release it, but please add a test 😄

[f11r]

@hjacobs tests/decorators/test_validation.py seems to only have tests for `ParameterValidator. Is this still the correct file to add a test or could you point me to the correct place to add it? I'm not really familiar with the tests here.

[hjacobs]

@f11r I think you can add it here: https://github.com/zalando/connexion/blob/6668835420231c15095a71e264b2e2b0e1a68bf3/tests/api/test_responses.py#L203

It currently only tests the status code (415) on "wrong" content type (i.e. not the case where Content-Type is missing).

[f11r]

It actually looks like you already did have the correct test here https://github.com/zalando/connexion/blob/6668835420231c15095a71e264b2e2b0e1a68bf3/tests/api/test_responses.py#L213, but werkzeug always sets Content-Type to an empty string if not provided in the post. I opened an issue (pallets/werkzeug#1159) over there.

[hjacobs]

@f11r maybe you can do an "artificial" manual HTTP request in the test and not use the test client?

[f11r]

Added a test, not particularly pretty. Not sure if something like requests.post() could actually work since if I understand it correctly the test server is just a "fake"-server.

[hjacobs]

Hmm, test is failing now: https://travis-ci.org/zalando/connexion/jobs/260553758

[f11r]

I seem to be on a roll here :D

In a clean python3.5 environment running pip install -r requirements-devel.txt && pip install typing && python setup.py test works, while pip install pytest typing && python setup.py test fails (on a unrelated note, typing seems to be missing somewhere so that I have to install it manually).

I'll try to figure out why tomorrow.

[coveralls]

Coverage remained the same at 100.0% when pulling ee72325 on f11r:master into d51e9c8 on zalando:master.

[f11r]

Figured out what is going on: app_client is a flask.testing.FlaskClient which does not support passing an environment as the only argument to open() in flask<=0.12.2. This was only implemented recently in pallets/flask#2412. That's why it succeeded for the development builds but not for the "real" builds. I implemented a workaround but that doesn't make the test any prettier.

[jmcs]

Can you move this import to the top level (beginning of the file)?

[f11r]

done

[coveralls]

Coverage remained the same at 100.0% when pulling 07ce38b on f11r:master into d51e9c8 on zalando:master.

[jmcs]

👍