Drop swagger-ui v2 in favor of v4 #22
Conversation
| swagger_ui_3_path = swagger_ui_3_52_0_path | ||
| swagger_ui_4_path = swagger_ui_4_4_0_path | ||
|
|
||
| # default to swagger 3 | ||
| swagger_ui_path = swagger_ui_3_path |
There was a problem hiding this comment.
Kept v3 as default for now to limit impact of change.
But since a major version update is needed anyway, we might want to change it to v4 already.
|
Hi @dtkav, replying to spec-first/connexion#1429 (comment) here:
No worries about getting back, this isn't urgent. I was just testing a The only jinja templating I could find, was in index.j2, which I included for v4 as well. Let me know if there is something I missed. |
|
Can we get this merged please? Even the swagger v3.52.0 that is currently there has open CVEs. |
|
@dtkav you once proposed to donate this repository to the spec-first organization as well. Happy to support it there if this is still something you want. |
|
Hello @RobbeSneyders , |
|
@dtkav any update on this PR or on moving the repository to spec-first? |
|
I have given up on this project and am now pointing connexion to an upgraded swagger-ui dist directory that I have checked in to my repo. |
|
FYI: since looks like there's no more activity on this project (seems abandoned) I've forked it and added support for version 4 (and removed support for versions 2 and 3) there: https://github.com/bartsanchez/swagger_ui_bundle Maybe you could find it useful. |
|
Merged in #32 |
Fixes #20.
Dropping v2 means we lose support for swagger / openapi versions 1.X.
However, swagger 2.0 was released in 2014 and Swagger 1.X doesn't seem to get a lot of usage anymore.
This is a breaking change, so I would propose to release this with a major version bump.