Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same syntax highlighting elements as tabatkins/highlighter #1313

Closed
domenic opened this issue Jul 11, 2018 · 0 comments
Closed

Use same syntax highlighting elements as tabatkins/highlighter #1313

domenic opened this issue Jul 11, 2018 · 0 comments

Comments

@domenic
Copy link
Collaborator

domenic commented Jul 11, 2018

In 7a022f4 we removed syntax highlighting inline styles from WHATWG specs under the assumption that https://github.com/whatwg/whatwg.org/pull/209/files would suffice. However, it appears Bikeshed-produced specs don't use the special custom elements/attributes that tabatkins/highlighter does. So, right now all WHATWG specs are missing highlighting -_-.

domenic added a commit to whatwg/whatwg.org that referenced this issue Jul 11, 2018
We accidentally broke it in speced/bikeshed@7a022f4, thinking the block added in #209 would suffice, but due to speced/bikeshed#1313 it does not work yet.

While waiting for speced/bikeshed#1313 to be fixed, include these styles, to un-break syntax highlighting.
domenic added a commit to whatwg/whatwg.org that referenced this issue Jul 23, 2018
We accidentally broke it in speced/bikeshed@7a022f4, thinking the block added in #209 would suffice, but due to speced/bikeshed#1313 it does not work yet.

While waiting for speced/bikeshed#1313 to be fixed, include these styles, to un-break syntax highlighting.
TimvdLippe added a commit to TimvdLippe/whatwg.org that referenced this issue Aug 3, 2018
speced/bikeshed#1313 has been resolved, thus the styles can once again be removed.
They were introduced in whatwg#214
domenic pushed a commit to whatwg/whatwg.org that referenced this issue Aug 9, 2018
speced/bikeshed#1313 has been resolved, thus the styles can once again be removed.

They were introduced in #214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant