-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WHATWG Commit Snapshot computed metadata #1635
Conversation
They will now use a title aligned with Review Drafts, use the snapshot logo, and generally include less data that is best looked for in the Living Standard. Depends upon speced/bikeshed#1635. Closes whatwg/meta#88. Closes #309.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could go further, updating computed-metadata.include
to replace [SNAPSHOT-LINK]
with a line that uses [COMMIT-SHA]
. Then we could remove all the lines in the deploy script that deal with SNAPSHOT-LINK
.
Finally we could also move the warning stuff here by adding a header-LS-COMMIT
, similar to what we did for header-RD
.
bikeshed/boilerplate/whatwg/computed-metadata-LS-COMMIT.include
Outdated
Show resolved
Hide resolved
bikeshed/boilerplate/whatwg/computed-metadata-LS-COMMIT.include
Outdated
Show resolved
Hide resolved
Duplicating the whole header to remove the need for |
Hmm. I like the way it keeps things centralized, but I see what you mean. There's probably also a way of avoiding the duplication, but I can try to make that work on top of this. |
OK, I:
We should probably not merge this until all three of us are online and can sync the whatwg.org PR and discuss whether it's the best strategy. But, I'm pretty happy with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot approve this, but I'm happy with it.
e216180
to
e1460e7
Compare
@domenic I checked with Tab and I can land this once we know what we want |
OK, this is ready. It adds a new status, |
|
Buids upon speced/bikeshed#1635. Remaining work tracked by whatwg/spec-factory#5. Closes whatwg/meta#88. Closes #309. Co-authored-by: Domenic Denicola <d@domenic.me>
The recent changes in speced/bikeshed#1635 also need to be reflected into the spec Makefiles.
The recent changes in speced/bikeshed#1635 also need to be reflected into the spec Makefiles.
@tabatkins api.csswg.org picks this up immediately, right? We need to change our invocation of that and I wonder how we need to balance things.
cc @domenic