Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for displaying Can I Use compat data summaries in specs #824

Merged
merged 1 commit into from
Oct 4, 2016
Merged

Add support for displaying Can I Use compat data summaries in specs #824

merged 1 commit into from
Oct 4, 2016

Conversation

cvrebert
Copy link
Contributor

Fixes #645. I've tried to take all the suggestions from there into account.
This currently generates the same DOM structure as the panels in the WHATWG HTML spec.
Due to licensing uncertainties, this does not include the CSS snippet from WHATWG HTML.

@cvrebert
Add support for displaying Can I Use compatibility data summaries in …
b5765e2 
…specs

Enabled via a new "Include Can I Use Panels" metadata setting.
Add the Can I Use feature ID as a `caniuse` attribute on a term definition to
generate a Can I Use panel near the term.

Fixes #645
@cvrebert
Copy link
Contributor Author

cvrebert commented Oct 2, 2016

The Travis error is presumably due to this introducing a new data file, and bikeshed update not being part of the build script, hence said file is MIA.

@tabatkins tabatkins merged commit 5e021b4 into speced:master Oct 4, 2016
@tabatkins
Copy link
Collaborator

Looks good on review. I'll check it personally, but merged right now.

@kba
Copy link
Contributor

kba commented Oct 4, 2016

Could this have broken the https://api.csswg.org/bikeshed/ webservice?

For a curl -L https://api.csswg.org/bikeshed/ -F file=foo.bs request, I'm getting 400 with

Error running preprocessor, returned code: 1.
FATAL ERROR: Couldn't retrieve the file 'caniuse.json' from cache. Something's wrong, please report this.
 ✘  Did not generate, due to fatal errors

and if I add -F force=1, I'm getting a 400 with a blank body.

@tabatkins
Copy link
Collaborator

Yes, it'll do that. I'll push the data files real quick.

@kba
Copy link
Contributor

kba commented Oct 4, 2016

Ah, okay, just weird timing, one second it worked, the other it didn't and I wondered what Caniuses might be and where they came from all of a sudden 😆

@tabatkins
Copy link
Collaborator

Ahahaha, that's great. It works now, tho?

@kba
Copy link
Contributor

kba commented Oct 4, 2016

It does, thank you! 🙇‍♂️

@tabatkins
Copy link
Collaborator

@cvrebert Ok, I merged in the WHATWG styling, did some style adjustments to the code, and switched the panels to be <aside>s appended to <body> and positioned with JS (same as the dfn panels); otherwise they'll auto-close <p>.

@cvrebert cvrebert deleted the can-i-use branch October 5, 2016 02:07
@cvrebert
Copy link
Contributor Author

cvrebert commented Oct 5, 2016

@tabatkins Wow, that was fast. Looks great! Thanks.

@cvrebert cvrebert mentioned this pull request Oct 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvrebert @tabatkins @kba