Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache buster breaks periodically #2102

Open
grantfitzsimmons opened this issue Sep 6, 2022 · 5 comments
Open

Cache buster breaks periodically #2102

grantfitzsimmons opened this issue Sep 6, 2022 · 5 comments
Labels
1 - Bug Incorrect behavior of the product todo:verify Needs Verification

Comments

@grantfitzsimmons
Copy link
Member

image

After modifying a view definition, I want to clear my cache. I sometimes (every 2-3 times) have the cache buster break.

image

It is common enough that I log out and log back in instead of trying to use it when modifying forms.

@maxpatiiuk
Copy link
Member

Fixed on agent-merging branch in c67873b by silencing the errors that occur as part of cache busting

@maxpatiiuk maxpatiiuk linked a pull request Mar 18, 2023 that will close this issue
@grantfitzsimmons
Copy link
Member Author

Soraya at Bern reported this today!

@grantfitzsimmons grantfitzsimmons removed a link to a pull request Jun 13, 2023
@grantfitzsimmons
Copy link
Member Author

grantfitzsimmons commented Jun 13, 2023

Maybe it will be resolved on the xml-editor branch. @specify/ux-testing can you make sure?

@pashiav
Copy link
Contributor

pashiav commented Dec 18, 2023

Cache is not being cleared.

The amount of cache in chrome settings is the exact same after using the "Clear Browser Cache" tool.
issue-2102

tested on branch edge on dbs: Gothenburg_12_07_23 and nbm_mnb_5_5_23

@maxpatiiuk
Copy link
Member

that's a smart way to check this!
but...I am not sure if that amount would be affected by this (at least not noticeably)

reasons:
  • many of the cached files for which cache is being cleared are very small (under 1mb total)
  • the way the cache buster works is that it tells browser to make a fetch a file again, "and to not look into cached version if cached version is older than 0s", but this does not prevent the browser from caching the file again right after the request

thus, for verifying this bug, I would suggest finding an actual app resource or view definition that is still stale after cleaning the cache
OR running the cache buster and seeing if this error still happens (like in the original comment in this issue)

to verify that an error message is discarded silently rather than shown to the user, you would need to either:

(this might get a bit too technical, so feel free to ask for assistance)

at the same time, the fix is relatively simple, and the exact same fix has already been applied in other places and tested working correctly, so it might not be worth spending too much time verifying it here

@emenslin emenslin added the todo:verify Needs Verification label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product todo:verify Needs Verification
Projects
Status: 📋 Backlog
Development

No branches or pull requests

4 participants