Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop centering text when it overflows #3227

Closed
grantfitzsimmons opened this issue Mar 21, 2023 · 8 comments · Fixed by #2579
Closed

Stop centering text when it overflows #3227

grantfitzsimmons opened this issue Mar 21, 2023 · 8 comments · Fixed by #2579
Assignees
@grantfitzsimmons @CarolineDenis
Labels
1 - Request A request made by a member of the community

Comments

@grantfitzsimmons
Copy link
Member

image

I am not a fan of centered text in general, but especially in menus that have a bunch of left-aligned text. This change was introduced recently (likely related to the changes for 400% zoom) and it has perturbed me every time it happens. It should remain left-aligned even on overfill.
@grantfitzsimmons grantfitzsimmons added 1 - Request A request made by a member of the community pri:unknown labels Mar 21, 2023
@grantfitzsimmons grantfitzsimmons changed the title Stop centering items when they overflow Stop centering text when they overflow Mar 21, 2023
@grantfitzsimmons grantfitzsimmons changed the title Stop centering text when they overflow Stop centering text when it overflow Mar 21, 2023
@grantfitzsimmons grantfitzsimmons changed the title Stop centering text when it overflow Stop centering text when it overflows Mar 21, 2023
@maxpatiiuk
Copy link
Member

maxpatiiuk commented Mar 24, 2023 •
edited
Loading

@CarolineDenis could you confirm/disconfirm that this change was made recently, see what specific line change caused this and check if we can undo it?

tools like git blame, git log and git diff would be helpful for this. Read more about them online if needed

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Front-End Backlog Mar 24, 2023
@CarolineDenis
Copy link
Contributor

Cannot reproduce this issue

@maxpatiiuk
Copy link
Member

Try reproducing in firefox

@CarolineDenis
Copy link
Contributor

Couldn't replicate in Firefox

@grantfitzsimmons
Copy link
Member Author

This happens a lot (including during demos at our meetings)

@grantfitzsimmons
Copy link
Member Author

image

@grantfitzsimmons
Copy link
Member Author

Not a huge deal, but not a big fan

@CarolineDenis CarolineDenis mentioned this issue Apr 18, 2023
Closed
CarolineDenis added a commit that referenced this issue Apr 18, 2023
@CarolineDenis
Align notifications to the left
63a4110 
Fixes #3227
@maxpatiiuk
Copy link
Member

Fixed in fc00e2b and e9d2d2e on agent-merging branch

@maxpatiiuk maxpatiiuk linked a pull request Apr 19, 2023 that will close this issue
Agent merging #2579
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Front-End Backlog May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grantfitzsimmons grantfitzsimmons

@CarolineDenis CarolineDenis

Labels
1 - Request A request made by a member of the community
Projects
Front-End Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Agent merging specify/specify7
Align notifications to the left specify/specify7
3 participants
@grantfitzsimmons @maxpatiiuk @CarolineDenis