-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Workbench to React completely #4611
Comments
I would say this issue is a duplicate of #2622
|
also you did a great analysis of what each of these files is doing - described it better and more succinctly than I could! |
Thank you Max. Closed the older issue. From @maxpatiiuk
|
Currently, some parts of the Workbench are written in React while some parts still use Backbone.js/jQuery. The workbench also uses the handsontable library to view/interact with spreadsheet data, which needs to refactored to its React version.
Additionally, some parts of the Workbench use TypeScript classes which may be converted to React hooks if needed.
Relevant files that potentially need to be migrated/refactored:
WorkBench/WbView.tsx
: Entrypoint for the WorkBench which handles most interactions. Needs migration.WorkBench/WbActions.tsx
: Vanilla TS class. Can potentially be converted to a hookWorkBench/WbUtils.tsx
: Needs migration. Uses Backbone.jsWorkBench/WbValidation.tsx
: Vanilla TS class. Can potentially be converted to a hookWorkBench/CellMeta.tsx
: Vanilla TS class. Can potentially be converted to a hookWorkBench/DisambiguationLogic.tsx
: Vanilla TS class. Can potentially be converted to a hookWorkBench/handsontable.ts
: Contains several functions to set configuration of handsontable. Might need some minor refactoring based on changes in other files.WorkBench/Template.tsx
: Has multiple components that render a part of Workbench. Generates static template for theWbView
(Backbone) using React.WorkBench/DataSetMeta.tsx
: Contains one Backbone.js ViewDataSetNameView
WorkBench/hooks.ts
: Might need some minor refactoring based on changes in other files.The text was updated successfully, but these errors were encountered: