Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Workbench to React #4637

Merged
merged 161 commits into from
May 20, 2024
Merged

Migrate Workbench to React #4637

merged 161 commits into from
May 20, 2024

Conversation

sharadsw
Copy link
Contributor

@sharadsw sharadsw commented Mar 11, 2024 •
edited
Loading

Fixes #4611

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Test all features described here
https://discourse.specifysoftware.org/t/the-specify-7-workbench/540

@sharadsw
Copy link
Contributor Author

sharadsw commented Mar 11, 2024 •
edited
Loading

The handsontable react wrapper requires handsontable >= 12. I've upgraded it to 12.1.0 (and also fixed resulting type errors) as newer versions don't render on the Workbench for some reason. Will upgrade it to the latest version after completing migration as the migration is going to change how handsontable is rendered.

@CarolineDenis CarolineDenis added this to the 7.9.5 milestone Mar 13, 2024
@maxpatiiuk
Copy link
Member

Hi
Would you prefer I review this PR every once in a while after you push a few commits, or only when you explicitly assign it to me for review/re-review?
Some devs like to get feedback right away and incrementally, while others only want it when everything looks is finished

@sharadsw
Copy link
Contributor Author

I think a review at the end would be great!

sharadsw and others added 16 commits May 16, 2024 16:56
@sharadsw
block column reorder in results view
687fd7a
@sharadsw
remove ternary for rollback
89b0d4d
@sharadsw
remove ternary in actions
848bf5f
@sharadsw @github-actions
Lint code with ESLint and Prettier
484c024 
Triggered by 687fd7a on branch refs/heads/issue-4611
@sharadsw
Merge remote-tracking branch 'origin/issue-4611' into issue-4611
ee11564
@sharadsw @github-actions
Lint code with ESLint and Prettier
02d367c 
Triggered by ee11564 on branch refs/heads/issue-4611
@sharadsw
add f.fastParseInt
fea2d2b
@sharadsw
Merge remote-tracking branch 'origin/issue-4611' into issue-4611
98e4331
@sharadsw
improve cellMeta types
2394d54
@sharadsw @github-actions
Lint code with ESLint and Prettier
39a6597 
Triggered by 98e4331 on branch refs/heads/issue-4611
@sharadsw
remove falsy checks for workbench.hot
196b15e
@sharadsw
Improve method access in CellMeta, Disambiguation and Validation
3dbe8aa 
- also makes triggerLiveValidation async
- adds return types
- makes parseRowValidationResults more readable
@sharadsw
Merge remote-tracking branch 'origin/issue-4611' into issue-4611
60f8121
@sharadsw @melton-jason
remove ternary for showResults
3005137 
Co-authored-by: Jason Melton <64045831+melton-jason@users.noreply.github.com>
@sharadsw
merge imports
0901068
@sharadsw @github-actions
Lint code with ESLint and Prettier
c1d37ca 
Triggered by 0901068 on branch refs/heads/issue-4611
@sharadsw sharadsw requested a review from melton-jason May 17, 2024 14:08
melton-jason
melton-jason requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@melton-jason melton-jason left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 💯

It looks like one of the changes introduced an bug in which changes which are not caused by undo/redo are not triggering the save button:

Screen.Recording.2024-05-17.at.11.03.46.AM.mov

specifyweb/frontend/js_src/lib/components/WorkBench/hooks.ts Outdated Show resolved Hide resolved
@sharadsw @melton-jason
Fix save button not triggering
2b4d619 
Co-authored-by: Jason Melton <64045831+melton-jason@users.noreply.github.com>
@sharadsw sharadsw requested a review from melton-jason May 17, 2024 16:53
@sharadsw @github-actions
Lint code with ESLint and Prettier
3fd6d6b 
Triggered by 2b4d619 on branch refs/heads/issue-4611
melton-jason
melton-jason approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@sharadsw sharadsw merged commit 1de4a30 into production May 20, 2024
9 checks passed
@sharadsw sharadsw deleted the issue-4611 branch May 20, 2024 12:51
@melton-jason melton-jason mentioned this pull request May 20, 2024
Merged
4 tasks
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-5-release-announcement/1751/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Areyes42 Areyes42 Areyes42 left review comments

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@grantfitzsimmons grantfitzsimmons grantfitzsimmons left review comments

@lexiclevenger lexiclevenger lexiclevenger approved these changes

@emenslin emenslin emenslin approved these changes

@CarolineDenis CarolineDenis CarolineDenis approved these changes

@combs-a combs-a combs-a approved these changes

@melton-jason melton-jason melton-jason approved these changes

@alesan99 alesan99 alesan99 approved these changes

@acwhite211 acwhite211 acwhite211 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.5
Development

Successfully merging this pull request may close these issues.

Migrate Workbench to React completely