-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infer scoping for attachments #3315
Open
melton-jason
wants to merge
8
commits into
production
Choose a base branch
from
issue-3289
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpatiiuk
requested changes
Apr 7, 2023
grantfitzsimmons
requested changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://coldfish-issue-3289.test.specifysystems.org/specify/view/treatmentevent/new/
I uploaded a single attachment to this treatment event and received the following error:
TypeError at /api/specify/treatmentevent/ cannot unpack non-iterable method object Request Method: POST Request URL: http://coldfish-issue-3289.test.specifysystems.org/api/specify/treatmentevent/
Same issue on permit |
maxpatiiuk
approved these changes
Apr 14, 2023
@melton-jason Can you see if this can be investigated over the next couple of weeks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3289
Every attachment must have a
scope type
andscope id
. The way the backend handles assigning scope type and scope id for attachments is to get the scoping of the 'attachee' record. Previously, this scoping was hard-coded in ascoping
python file.This pull request is an extension of the changes made in #2744
Here are a list of all attachment tables in Specify
Previously, only the following attachment tables were supported
With these changes, the backend should try and infer the scoping of tables based on if they have any of the relationships commonly used for scoping (
division_id
,discipline_id
,collectionmemberid
,collection_id
).If the table contains more than one of the scoping relationships, it will assign scoping based in the following priorities:
Here is how the following tables should be scoped: