-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement attachment viewer gallery in record sets #3363
Conversation
Triggered by 5e93f97 on branch refs/heads/issue-3316
specifyweb/frontend/js_src/lib/components/Attachments/Gallery.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/index.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/FormSliders/RecordSelectorFromIds.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/FormSliders/RecordSelectorFromIds.tsx
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
To test: |
specifyweb/frontend/js_src/lib/components/FormSliders/RecordSelectorFromIds.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Attachments/RecordSetAttachment.tsx
Outdated
Show resolved
Hide resolved
Triggered by 082e72c on branch refs/heads/issue-2132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fetching more attachments results in obtrusive loading dialog. Also, the number of attachments displayed at the top of the viewer seems to count the number of attachments currently fetched, not total number of attachments. Expected?
Cm6o3fwtSF.mp4
Cannot edit attachments through attachment viewer gallery. Must navigate to the associated record and make edits there to see changes in attachment viewer gallery, and then reload to see changes in the record set. LG3kFqbsXa.mp4 |
Triggered by dab39e4 on branch refs/heads/issue-2132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skeleton loader looks really nice. But fetching more records seems to fetch every remaining record. Also, the loading gifs appear right before records are finally loaded and noticed slight cutoff on the right side of the third column of attachments.
8vVq0dw0BZ.mp4
@chanulee1: regarding your comment "noticed slight cutoff on the right side of the third column of attachments." Screen.Recording.2023-05-22.at.8.54.13.AM.mov |
I was on Chrome too... Strange |
Yes, the cut-off was likely caused by manually resizing the dialog. |
Hmm. The cutoff seems to happen for me no matter how it is resized. It looks like it is because of the thickness of the scrollbar? @CarolineDenis For some reason the scroll bar appears different in our videos. Not sure what determines this. SepSL92k3R.mp4 |
As far as I know, by default the scrollbars are determined by your Operating System. |
Triggered by d347557 on branch refs/heads/issue-2132
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
issue-2132.mov
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-2-release-announcement/1452/1 |
Fixes #2132