Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Es localization #3469

Merged
merged 12 commits into from
May 17, 2023
Merged

Es localization #3469

merged 12 commits into from
May 17, 2023

Conversation

maxpatiiuk
Copy link
Member

Improve Spanish Localization (by Iñigo Granzow de la Cerda <igranzow@rjb.csic.es>)

To test:
review the changed files briefly to make sure nothing looks odd (i.e, make sure no stray ) or '' were introduced)

@maxpatiiuk maxpatiiuk requested review from grantfitzsimmons and a team and removed request for grantfitzsimmons May 8, 2023 20:54
Triggered by fef3b43 on branch refs/heads/es-localization
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes we should make– but it looks fine

@grantfitzsimmons grantfitzsimmons requested a review from tlammer May 10, 2023 21:01
Split code to fix circular dependencies
Now just to add weblate back to schema (most of the code is shared)
Despite JSON being one of my favorite data formats, it's not very
user friendly. JSON5 and JSON6 are better
@maxpatiiuk
Copy link
Member Author

@grantfitzsimmons I don't think a PR is the best place for reviewing localization changes.
Weblate is made exactly for that.
If there aren't any other major issues, I propose we merge this and continue further improvements to Spanish localization in Weblate

@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented May 16, 2023

@maxpatiiuk Let's merge this and continue in Weblate

@maxpatiiuk maxpatiiuk enabled auto-merge May 17, 2023 00:35
@maxpatiiuk maxpatiiuk disabled auto-merge May 17, 2023 00:35
@maxpatiiuk maxpatiiuk merged commit 0a02361 into production May 17, 2023
@maxpatiiuk maxpatiiuk deleted the es-localization branch May 17, 2023 00:40
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-12-release-announcement/1202/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants