Create CSV export with only selected query rows

[CarolineDenis]

Fixes #2348

[maxpatiiuk]

@CarolineDenis since this branch was based on specify-network-integration, you should pick it as your pull request merge target rather than production

[grantfitzsimmons]

@maxpatiiuk @CarolineDenis Can this change be transferred to production as we have no timeline for release yet for specify-network-integration? That may mean creating a new PR

[maxpatiiuk]

@grantfitzsimmons
It's on this branch specifically because this branch modified the relevant code
specify network integration can be released as soon as it's tested - it has all the features I wanted it to have for v1
the collection-wide gbif maps are also there, but they are not linked to from anywhere yet

[maxpatiiuk]

After thinking futher about this code, I do like your solution of making selectedRows accessible to parent components as this might even be useful for other use cases in the future.

The only advice I have here is to change resultsArray from being a state to being a ref. Please think though implications of this change (i.e, what's the difference between state and ref, especially when it comes to triggering react re-renders) and why it's beneficial to do that change in here

[carlosmbe]

Works. But exported files with only selected rows were .tsv
Not sure if collection managers are picky about that but maybe change the button to Create TSV in those situations

[maxpatiiuk]

Works. But exported files with only selected rows were .tsv Not sure if collection managers are picky about that but maybe change the button to Create TSV in those situations

Good catch! The code should not be hardcoded to use .tsv extension - you should either use .csv (which is a universal file extension for this type of data), or have a different file extension depending on the delimiter used (.tsv - tab, .csv - comma, .psv - pipe, and others)

The button however should always say Create CSV as CSV is far more recognizable to an average computer user than more obscure formats like TSV or PSV

[carlosmbe]

Works. But exported files with only selected rows were .tsv
Not sure if collection managers are picky about that but maybe change the button to Create TSV in those situations

Also the naming format of the exported files differs:

query_results_2023-05-22T20_21_21.052320.csv

vs

taxon query - Mon May 22 2023.tsv

[carlosmbe]

Mainly related to maintaining consistency with the old Create CSV
Two things:
1- The old Create CSV lets users download the file through the notifications while selected query are automatically downloaded.
2- Naming format of the exported files still differs from the old Create CSV

[maxpatiiuk]

Yes, we should improve the back-end file name. But, Caroline created a separate issue for that, so it doesn't necessarily have to be fixed as part of this PR - #3525

As far as using notifications:

1. The notifications system was used due to technical limitations (because it needs time to fetch all query results and generate the file) - here there is no reason to wait because the query results are already fetched (because user can only select query results that are fetched).
2. Front-end has not technical capability to send someone notifications, so we can't use that - only back-end has the power to create notifications at the moment.

Thus, this inconsistency is justified

[bronwyncombs]

v7.8.12-prerelease : The Create CSV button adds selected rows only to the download file. The file name format is Query Name - Day Date.

[melton-jason]

@bronwyncombs can you expand upon this please? What exactly did you find while testing this?
Can you describe what you were doing (so we can recreate an issue)?
Screenshots, Videos, or direct links are always helpful for this process as well!
Essentially, try and format your response like an Issue (if you don't know how issues are formatted, check out any of them from the Issues tab!).
Because of this, it may be easier to open an Issue and link the associated Pull Requests (or other Issues) with # and then entering the ID or the name.

I tested this on v7.8.12-prerelease and here are my results.

When exporting a query to CSV that has not been saved, it exports correctly (only the selected rows).
However, there was an issue related to the name of the Query (most likely related to #3525) .

The Query name is New Query -_ Collection Object - Fri Jun 02 2023.csv.
There seems to be extra space characters.

New Query -_ Collection Object - Fri Jun 02 2023.csv

Exporting a saved Query seems to work as intended. The selected rows export properly, and the file is named correctly.

CO Query - Fri Jun 02 2023.csv