Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight interaction menu item when in interaction forms #3481

Merged
merged 6 commits into from
May 15, 2023
Merged

Highlight interaction menu item when in interaction forms #3481

merged 6 commits into from
May 15, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3459

@CarolineDenis CarolineDenis requested a review from maxpatiiuk May 11, 2023 18:00
@CarolineDenis
Fix failing test
3b7db4e
@CarolineDenis @github-actions
Lint code with ESLint and Prettier
eb5ab19 
Triggered by 3b7db4e on branch refs/heads/issue-3459
@CarolineDenis CarolineDenis requested a review from maxpatiiuk May 12, 2023 16:11
@CarolineDenis @github-actions
Lint code with ESLint and Prettier
be225c7 
Triggered by 71b9edc on branch refs/heads/issue-3459
@grantfitzsimmons grantfitzsimmons self-requested a review May 12, 2023 19:37
maxpatiiuk
maxpatiiuk requested changes May 14, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code has faulty logic
As a result, this doesn't work correctly for record sets based on an interaction table

specifyweb/frontend/js_src/lib/components/Forms/ShowResource.tsx Outdated Show resolved Hide resolved
@CarolineDenis CarolineDenis requested a review from maxpatiiuk May 15, 2023 17:09
@CarolineDenis CarolineDenis merged commit 397771b into production May 15, 2023
@CarolineDenis CarolineDenis deleted the issue-3459 branch May 15, 2023 17:21
@carlosmbe carlosmbe mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@grantfitzsimmons grantfitzsimmons grantfitzsimmons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Side Bar Menu highlights the wrong item
3 participants
@CarolineDenis @grantfitzsimmons @maxpatiiuk