Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show quotes after auto-generated query names #3532

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

grantfitzsimmons
Copy link
Member

Solves #3126

Changed

    'en-us': '{tableName:string} using "{nodeFullName:string}"',

to this

    'en-us': `{tableName:string} using "{nodeFullName:string}"`,

Will this have any implications for Weblate? In my testing it solves the quote issue.

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Weblate won't have a problem with you manually changing localization files

@grantfitzsimmons grantfitzsimmons requested a review from a team May 25, 2023 18:46
Copy link
Contributor

@chanulee1 chanulee1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quotes present after auto-generated query names.

@grantfitzsimmons grantfitzsimmons merged commit ca5c769 into production May 26, 2023
@grantfitzsimmons grantfitzsimmons deleted the issue-3126 branch May 26, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants