-
Notifications
You must be signed in to change notification settings - Fork 42
Add a feature to choose type of taxon tree in WB #5091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TODO:
(@acwhite211 ) |
specifyweb/frontend/js_src/lib/components/WbPlanView/navigator.ts
Outdated
Show resolved
Hide resolved
|
IIRC, we were going to make it so that users select treedef when they open CO form. It'd absolutely simplify things here too... Also, this is simpler and more straightforward on the backend than the query builder...provided upload plan identifies the tree for us |
|
NOTES:
|
This was a discussion we had during a meeting but we decided not to go with this solution |
|
NOTES:
MISSING 🚨 🚨:
|
|
NOTES: Need to remove: when selecting Taxon as base table in the WB, the user is now presented a list of available tree to upload to Implement a first column in the query mapper with the trees and only when selected the ranks, same in the query lines |
|
NOTES:
|
realVinayak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for testing out the root issue!!
maxpatiiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice feature!
most of the code looks good.
have questions about the newly added mapping path symbols
specifyweb/frontend/js_src/lib/components/WbPlanView/mappingHelpers.ts
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/WbPlanView/mappingHelpers.ts
Outdated
Show resolved
Hide resolved
Triggered by e56e82c on branch refs/heads/issue-4980
more in 7.9.8
|
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1 |
Fixes #4980
Checklist
and self-explanatory (or properly documented)
Testing instructions
I created a database named 'sp7demofish_mots.sql' on the test panel, this has some sample Taxon trees created to use in this PR's test. Use the screenshots for extra testing details.
Here is a test panel instance to use: https://sp7demofishmots-issue-4980.test.specifysystems.org