-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing coordinate text fields for decimal coordinates #5368
Draft
grantfitzsimmons
wants to merge
1
commit into
production
Choose a base branch
from
issue-5365
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletions
38
specifyweb/specify/migrations/0012_coordinate_fields_fix.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Generated by Django 3.2.15 on 2024-11-02 00:46 | ||
|
||
from django.db import migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('specify', '0011_cascading_tree_nodes'), | ||
] | ||
|
||
operations = [ | ||
# There are cases from Specify 6 where Longitude and Latitude are captured as decimal values but | ||
# the accompanying text fields are not populated. In cases where the text fields are not populated, | ||
# it appears the records do not have coordinates. This script will populate the text fields with the | ||
# decimal values where the text fields are empty but the decimal values are not. | ||
migrations.RunSQL( | ||
""" | ||
UPDATE locality | ||
SET Lat1text = Latitude1 | ||
WHERE Lat1text IS NULL AND Latitude1 IS NOT NULL; | ||
|
||
UPDATE locality | ||
SET Long1text = Longitude1 | ||
WHERE Long1text IS NULL AND Longitude1 IS NOT NULL; | ||
|
||
UPDATE locality | ||
SET Lat2text = Latitude2 | ||
WHERE Lat2text IS NULL AND Latitude2 IS NOT NULL; | ||
|
||
UPDATE locality | ||
SET Long2text = Longitude2 | ||
WHERE Long2text IS NULL AND Longitude2 IS NOT NULL; | ||
""", | ||
# This SQL statment should not be reversed, but this allows for rollback | ||
reverse_sql='' | ||
) | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Update this with the last current migration in the specify app before merge