Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Refactor data wranglers and make a common factory #168

Closed
16 of 17 tasks
cjgrady opened this issue Mar 10, 2022 · 0 comments · Fixed by #197
Closed
16 of 17 tasks

Refactor data wranglers and make a common factory #168

cjgrady opened this issue Mar 10, 2022 · 0 comments · Fixed by #197
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cjgrady
Copy link
Contributor

cjgrady commented Mar 10, 2022

We need to add data wranglers for trees and matrices (which was always the plan) but the wrangler factory is at the occurrence data wrangler level.

Combine the data wrangler factories and ensure that all data wranglers are included. This may require that data wranglers become subclasses rather than methods.

Todo:

  • Create a _DataWrangler base class
  • Create an _OccurrenceDataWrangler base class
  • Determine how a factory can create instances in a generalized way
  • Implement a from_config class method, ideally on one of the base classes
  • Accepted Name wrangler
  • Attribute modifier wrangler
  • Bounding box wrangler
  • disjoint geometries wrangler
  • intersecting geometries wrangler
  • common format wrangler
  • decimal precision wrangler
  • coordinate conversion wrangler
  • minimum points wrangler
  • spatial index wrangler
  • unique localities wrangler
  • Add wranglers to factory
  • Tests for wrangler factory
@cjgrady cjgrady self-assigned this Mar 10, 2022
@cjgrady cjgrady added the enhancement New feature or request label Mar 10, 2022
@cjgrady cjgrady added this to the Version-3.1 milestone Mar 10, 2022
@cjgrady cjgrady mentioned this issue Mar 17, 2022
11 tasks
@cjgrady cjgrady linked a pull request Mar 17, 2022 that will close this issue
11 tasks
@cjgrady cjgrady removed a link to a pull request Mar 17, 2022
11 tasks
@cjgrady cjgrady mentioned this issue Mar 29, 2022
11 tasks
@cjgrady cjgrady linked a pull request Mar 29, 2022 that will close this issue
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant