This repository has been archived by the owner on Sep 4, 2024. It is now read-only.
Data wrangler refactor #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Status
Description
Refactor data wranglers to be more generic and classes. The wranglers are designed to be extended but have base functionality for building from a configuration dictionary (for the factory) and to have built-in reporting. Convert all of the old data wrangler functions to classes and add tests.
Link(s) to issue
#168
Todos
Added dependencies
This probably requires that we update our GDAL required version to 3+ because of OSGeo/gdal#1546. We would need to add some specific handling for either GDAL 2 or change to GDAL 2 and handle GDAL 3 but GDAL 2 hasn't had an update for 2+ years.