Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify and triangulate large meshes #201

Merged
merged 6 commits into from
Jun 30, 2024
Merged

Conversation

KatKatKateryna
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 23.33333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 21.20%. Comparing base (1127ea1) to head (b41765e).

Files Patch % Lines
speckle/converter/geometry/utils.py 26.08% 17 Missing ⚠️
speckle/converter/geometry/mesh.py 20.00% 4 Missing ⚠️
speckle/converter/layers/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #201      +/-   ##
==========================================
- Coverage   21.22%   21.20%   -0.02%     
==========================================
  Files          44       44              
  Lines        6351     6365      +14     
==========================================
+ Hits         1348     1350       +2     
- Misses       5003     5015      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KatKatKateryna KatKatKateryna merged commit f7564d3 into dev Jun 30, 2024
9 of 10 checks passed
@KatKatKateryna KatKatKateryna deleted the large_mesh_triangulation branch June 30, 2024 01:03
KatKatKateryna added a commit that referenced this pull request Jul 1, 2024
2.19 updates:
add GisFeature class
speed up raster conversions
simplify large polygon display Meshes on Send
specify QGIS max version
generate installers for Mac (we had it already, just needed a change in CI)


* add Gis feature class on send and receive (#195)

* send GisFeature

* remove display val from child geometries

* receive GisFeature

* fix

* ensure units are strings

* fix failing test

* qgis max version (#194)

* raster conversion speed (#193)

* draft based on c# (adjust offset/rotation; XY directions)

* speed up, no offset

* to test, add correction XY

* fixed

* final fixes

* move function out

* non-negative scale and dimensions

* more optimized renderers, fixed "correction" for rasters

* remove specklepy call in helpers

* Revert "remove specklepy call in helpers"

This reverts commit de002e0.

* rely on string type for dataStorage.currentUnits

* fix units format

* standardize WKT format (#197)

* updato to m1 resource on CI, aligned with specklesystems/speckle-sharp#3449 (no rosetta) (#204)

* raster renderer edge cases (#206)

* simplify and triangulate large meshes (#201)

* simplify and triangulate large meshes

* more clear logic with adding points

* apply coeff to inner rings

* fix indexError

* max pts

* updated links

* tags

* remove extra readme

* syntax error
KatKatKateryna added a commit that referenced this pull request Jul 25, 2024
* add Gis feature class on send and receive (#195)

* send GisFeature

* remove display val from child geometries

* receive GisFeature

* fix

* ensure units are strings

* fix failing test

* qgis max version (#194)

* raster conversion speed (#193)

* draft based on c# (adjust offset/rotation; XY directions)

* speed up, no offset

* to test, add correction XY

* fixed

* final fixes

* move function out

* non-negative scale and dimensions

* more optimized renderers, fixed "correction" for rasters

* remove specklepy call in helpers

* Revert "remove specklepy call in helpers"

This reverts commit de002e0.

* rely on string type for dataStorage.currentUnits

* fix units format

* standardize WKT format (#197)

* updato to m1 resource on CI, aligned with specklesystems/speckle-sharp#3449 (no rosetta) (#204)

* raster renderer edge cases (#206)

* simplify and triangulate large meshes (#201)

* simplify and triangulate large meshes

* more clear logic with adding points

* apply coeff to inner rings

* fix indexError

* max pts

* updated links

* tags

* remove extra readme

* syntax error

* send rasters properly with offsets

* receive raster with offsets

* note

* fix raster rotation on send
KatKatKateryna added a commit that referenced this pull request Jul 25, 2024
* add Gis feature class on send and receive (#195)

* send GisFeature

* remove display val from child geometries

* receive GisFeature

* fix

* ensure units are strings

* fix failing test

* qgis max version (#194)

* raster conversion speed (#193)

* draft based on c# (adjust offset/rotation; XY directions)

* speed up, no offset

* to test, add correction XY

* fixed

* final fixes

* move function out

* non-negative scale and dimensions

* more optimized renderers, fixed "correction" for rasters

* remove specklepy call in helpers

* Revert "remove specklepy call in helpers"

This reverts commit de002e0.

* rely on string type for dataStorage.currentUnits

* fix units format

* standardize WKT format (#197)

* updato to m1 resource on CI, aligned with specklesystems/speckle-sharp#3449 (no rosetta) (#204)

* raster renderer edge cases (#206)

* simplify and triangulate large meshes (#201)

* simplify and triangulate large meshes

* more clear logic with adding points

* apply coeff to inner rings

* fix indexError

* max pts

* updated links

* tags

* remove extra readme

* syntax error

* send rasters properly with offsets

* receive raster with offsets

* note

* fix raster rotation on send

* don't mess transforms on send

* ignore extruded Mesh on receive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant