fix(server): allow standard users to batch invite to server (#2150)

* fix(server): allow standard users to batch invite to server * added max 10 invite batch limit * minor change
specklesystems · Mar 20, 2024 · f9f490b · f9f490b
1 parent e406c5d
commit f9f490b
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/packages/server/assets/serverinvites/typedefs/serverInvites.graphql b/packages/server/assets/serverinvites/typedefs/serverInvites.graphql
@@ -14,7 +14,7 @@ extend type Mutation {
     @hasScope(scope: "users:invite")
 
   serverInviteBatchCreate(input: [ServerInviteCreateInput!]!): Boolean!
-    @hasServerRole(role: SERVER_ADMIN)
+    @hasServerRole(role: SERVER_USER)
     @hasScope(scope: "users:invite")
 
   streamInviteBatchCreate(input: [StreamInviteCreateInput!]!): Boolean!

diff --git a/packages/server/modules/core/graph/resolvers/projects.ts b/packages/server/modules/core/graph/resolvers/projects.ts
@@ -25,6 +25,7 @@ import {
 } from '@/modules/core/services/streams/management'
 import { createOnboardingStream } from '@/modules/core/services/streams/onboarding'
 import { removeStreamCollaborator } from '@/modules/core/services/streams/streamAccessService'
+import { InviteCreateValidationError } from '@/modules/serverinvites/errors'
 import { cancelStreamInvite } from '@/modules/serverinvites/services/inviteProcessingService'
 import {
   getPendingStreamCollaborators,
@@ -145,6 +146,14 @@ export = {
         Roles.Stream.Owner,
         ctx.resourceAccessRules
       )
+
+      const inviteCount = args.input.length
+      if (inviteCount > 10 && ctx.role !== Roles.Server.Admin) {
+        throw new InviteCreateValidationError(
+          'Maximum 10 invites can be sent at once by non admins'
+        )
+      }
+
       const inputBatches = chunk(args.input, 10)
       for (const batch of inputBatches) {
         await Promise.all(

diff --git a/packages/server/modules/serverinvites/graph/resolvers/serverInvites.ts b/packages/server/modules/serverinvites/graph/resolvers/serverInvites.ts
@@ -86,6 +86,13 @@ export = {
     async serverInviteBatchCreate(_parent, args, context) {
       const { input: paramsArray } = args
 
+      const inviteCount = paramsArray.length
+      if (inviteCount > 10 && context.role !== Roles.Server.Admin) {
+        throw new InviteCreateValidationError(
+          'Maximum 10 invites can be sent at once by non admins'
+        )
+      }
+
       // Batch calls so that we don't kill the server
       const batches = chunk(paramsArray, 50)
       for (const paramsBatchArray of batches) {